-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to periodic metric reader for push based exporters #2982
Default to periodic metric reader for push based exporters #2982
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2982 +/- ##
==========================================
+ Coverage 84.13% 84.72% +0.59%
==========================================
Files 258 258
Lines 9093 9095 +2
==========================================
+ Hits 7650 7706 +56
+ Misses 1443 1389 -54
|
…elemetry-dotnet into alanwest/default-periodic
: new PeriodicExportingMetricReader(metricExporter, metricReaderOptions.PeriodicExportingMetricReaderOptions.ExportIntervalMilliseconds); | ||
: new PeriodicExportingMetricReader( | ||
metricExporter, | ||
metricReaderOptions.PeriodicExportingMetricReaderOptions.ExportIntervalMilliseconds ?? 60000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea - Might be good to have the default outside of this extension in a constant somewhere; but I believe it is already defined somewhere else so using that is OK as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to a constant. The constant already defined is part of the SDK project and is internal so not accessible here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually come to think of it the right thing to do here is to just do new PeriodicExportingMetricReader(metricExporter);
. I've got a follow up PR to remove MetricReaderType
. I'll clean that up in that PR.
Fixes #2979.
The OTLP exporter was mistakingly defaulted to the manual metric reader.
With this PR:
PeriodicExportingMetricReader
now allows an infinite export interval.