-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setters for State, StateValues, and FormattedMessage fields for LogRecord. #2864
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2864 +/- ##
==========================================
+ Coverage 84.91% 85.24% +0.32%
==========================================
Files 259 259
Lines 9330 9330
==========================================
+ Hits 7923 7953 +30
+ Misses 1407 1377 -30
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself might be okay but want to allow sufficient time to fully analyze implications as we are close to 1.2 stable. Blocking to prevent accidental merge.
See https://github.com/open-telemetry/opentelemetry-dotnet/pull/2864/files#r807384255
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Fixes #2877.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes