Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setters for State, StateValues, and FormattedMessage fields for LogRecord. #2864

Closed
wants to merge 39 commits into from

Conversation

Yun-Ting
Copy link
Contributor

@Yun-Ting Yun-Ting commented Feb 5, 2022

Fixes #2877.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #2864 (9bb8beb) into main (733c59a) will increase coverage by 0.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2864      +/-   ##
==========================================
+ Coverage   84.91%   85.24%   +0.32%     
==========================================
  Files         259      259              
  Lines        9330     9330              
==========================================
+ Hits         7923     7953      +30     
+ Misses       1407     1377      -30     
Impacted Files Coverage Δ
src/OpenTelemetry/Logs/LogRecord.cs 96.92% <100.00%> (ø)
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 76.47% <0.00%> (-2.95%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 92.34% <0.00%> (+3.60%) ⬆️
...tation/OpenTelemetryProtocolExporterEventSource.cs 85.00% <0.00%> (+10.00%) ⬆️
.../OpenTelemetry/Logs/OpenTelemetryLoggerProvider.cs 94.11% <0.00%> (+11.76%) ⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 77.27% <0.00%> (+40.90%) ⬆️
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 78.57% <0.00%> (+42.85%) ⬆️

@Yun-Ting Yun-Ting marked this pull request as ready for review February 7, 2022 20:18
@Yun-Ting Yun-Ting requested a review from a team February 7, 2022 20:18
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself might be okay but want to allow sufficient time to fully analyze implications as we are close to 1.2 stable. Blocking to prevent accidental merge.
See https://github.com/open-telemetry/opentelemetry-dotnet/pull/2864/files#r807384255

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Feb 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@CodeBlanch CodeBlanch reopened this Apr 14, 2022
@Yun-Ting Yun-Ting closed this Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Issues and pull requests which have been flagged for closing due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make some fields in LogRecord mutable for consistency with Activity.
6 participants