Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to Self diagnostics from all components readme. #2856

Merged
merged 5 commits into from
Feb 4, 2022

Conversation

cijothomas
Copy link
Member

Currently, information about self diagnostics is under the readme file of the SDK. As most uses indirectly consume SDK, this information is hard to find.
Proposing to add this info to every component's readme.

This PR just adds this for OTLP Exporter. If this approach sounds reasonable, we can add it for every component.

@cijothomas cijothomas requested a review from a team February 3, 2022 20:50
cijothomas and others added 2 commits February 3, 2022 13:17
Co-authored-by: Alan West <3676547+alanwest@users.noreply.github.com>
Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪵 LGTM

Comment on lines +130 to +131
## Troubleshooting

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for more feedbacks before merging. The goal is to copy this to all the components, so want to make sure the content is fine :)

@cijothomas cijothomas merged commit 818d8c9 into open-telemetry:main Feb 4, 2022
@cijothomas cijothomas deleted the cijothomas/sdklog_link branch February 4, 2022 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants