Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor Resource::SanitizeValue method to be more readable #2761

Merged
merged 5 commits into from
Jan 11, 2022

Conversation

kiapanahi
Copy link
Contributor

Code clean-up for the SanitizeValue method on the Resource type.

@kiapanahi kiapanahi requested a review from a team December 24, 2021 09:39
@mic-max
Copy link
Contributor

mic-max commented Dec 27, 2021

LGTM thanks!

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #2761 (d9c27d5) into main (66ad39d) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2761      +/-   ##
==========================================
- Coverage   83.75%   83.59%   -0.17%     
==========================================
  Files         251      246       -5     
  Lines        8835     8724     -111     
==========================================
- Hits         7400     7293     -107     
+ Misses       1435     1431       -4     
Impacted Files Coverage Δ
src/OpenTelemetry/Resources/Resource.cs 95.34% <100.00%> (-0.49%) ⬇️
....TelemetryHttpModule/TelemetryHttpModuleOptions.cs 0.00% <0.00%> (-90.00%) ⬇️
....AspNet.TelemetryHttpModule/TelemetryHttpModule.cs 0.00% <0.00%> (-5.27%) ⬇️
...entation.AspNet/TracerProviderBuilderExtensions.cs
...umentation.AspNet/Implementation/HttpInListener.cs
...rumentation.AspNet/AspNetInstrumentationOptions.cs
...ry.Instrumentation.AspNet/AspNetInstrumentation.cs
...Implementation/AspNetInstrumentationEventSource.cs
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+5.88%) ⬆️
... and 1 more

@cijothomas cijothomas merged commit 4bf8ed4 into open-telemetry:main Jan 11, 2022
@kiapanahi kiapanahi deleted the refactor/resource-sanitizer branch January 11, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants