Clean up test cases by using consistent variable name #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
approved these changes
Nov 24, 2021
alanwest
approved these changes
Nov 24, 2021
Codecov Report
@@ Coverage Diff @@
## main #2672 +/- ##
=======================================
Coverage 82.27% 82.27%
=======================================
Files 249 249
Lines 8688 8688
=======================================
Hits 7148 7148
Misses 1540 1540 |
cijothomas
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while working on #2671.
This PR only changes one thing - for all the test cases, if they use
Sdk.CreateTracerProviderBuilder(), the corresponding local variable name should betracerProviderrather thansdk,openTelemetry,openTelemetrySdkorshutdownSignal(curious - why did we have this name).