Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor optimization for HistogramBuckets enumeration #2668

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Minor optimization for HistogramBuckets enumeration #2668

merged 1 commit into from
Nov 23, 2021

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Nov 23, 2021

Changes

  • Minor optimization for HistogramBuckets enumeration

@utpilla utpilla requested a review from a team November 23, 2021 23:23
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #2668 (4f72f2a) into main (fb161af) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2668   +/-   ##
=======================================
  Coverage   82.25%   82.26%           
=======================================
  Files         249      249           
  Lines        8689     8688    -1     
=======================================
  Hits         7147     7147           
+ Misses       1542     1541    -1
Impacted Files Coverage Δ
src/OpenTelemetry/Metrics/HistogramBuckets.cs 100.00% <100.00%> (ø)
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 73.33% <0.00%> (-0.96%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+5.88%) ⬆️

CodeBlanch
CodeBlanch approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit e7f026e into open-telemetry:main Nov 23, 2021
@utpilla utpilla deleted the utpilla/HistogramBuckets-Enumeration-Optimization branch November 3, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeBlanch CodeBlanch CodeBlanch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@utpilla @CodeBlanch @cijothomas