-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change http.path to http.target in aspnet and aspnetcore instrumentations #2266
Change http.path to http.target in aspnet and aspnetcore instrumentations #2266
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2266 +/- ##
==========================================
+ Coverage 79.09% 79.12% +0.02%
==========================================
Files 238 238
Lines 7488 7488
==========================================
+ Hits 5923 5925 +2
+ Misses 1565 1563 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, consider updating the changelog since this will affect the user.
We should update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Need to update the contrib repo files with the same changes.
http.path
is not a semantic convention defined by spec.http.path
was used in OpenCensus and is mapped tohttp.target
in OpenTelemetry as per this