Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up logging work #1341

Merged
merged 3 commits into from
Oct 12, 2020
Merged

Clean up logging work #1341

merged 3 commits into from
Oct 12, 2020

Conversation

reyang
Copy link
Member

@reyang reyang commented Oct 10, 2020

Related to #1308.

Changes

  • Moved the InMemory extension to the Microsoft.Extensions.Logging namespace to make it aligned with the .NET convention.
  • Extracted the custom processor/exporter example to a separate project, to keep the "get started" project really simple.
  • Minor clean up.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@reyang reyang requested a review from a team October 10, 2020 02:52
@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #1341 into master will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1341      +/-   ##
==========================================
+ Coverage   78.08%   78.11%   +0.03%     
==========================================
  Files         223      224       +1     
  Lines        6369     6369              
==========================================
+ Hits         4973     4975       +2     
+ Misses       1396     1394       -2     
Impacted Files Coverage Δ
...orter.InMemory/InMemoryExporterHelperExtensions.cs 0.00% <ø> (ø)
...rter.InMemory/InMemoryExporterLoggingExtensions.cs 0.00% <0.00%> (ø)
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 80.95% <0.00%> (+3.17%) ⬆️

@cijothomas cijothomas merged commit f68157f into master Oct 12, 2020
@cijothomas cijothomas deleted the reyang/log-example-cleanup branch October 12, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants