Fix dotnet CLI usage: additional deps support to roll-forward

[pjanotti]

Why

To fix dotnet CLI usage.

Fixes #1744

What

• Modify the shared store so it allows framework roll forward as configured for Roslyn, details here. This fixes the issues with dotnet CLI

Tests

• Add integration tests for typical dotnet CLI usage.

Checklist

• CHANGELOG.md is updated.
• Documentation is updated.
• New features are covered by tests.

[pellared]

opentelemetry-dotnet-instrumentation/.github/workflows/ci.yml

Lines 53 to 56 in f1717f9

	dotnet publish -f net7.0 -c Release ./test/test-applications/integrations/TestApplication.Smoke
	export OTEL_DOTNET_AUTO_HOME="${PWD}/bin/tracer-home"
	. ./instrument.sh
	./test/test-applications/integrations/TestApplication.Smoke/bin/Release/net7.0/publish/TestApplication.Smoke

We could change it (and one more place) to

          export OTEL_DOTNET_AUTO_HOME="${PWD}/bin/tracer-home"
          . ./instrument.sh
          cd test/test-applications/integrations/TestApplication.Smoke
          dotnet run -f net7.0

I think it was the case before we bumped to .NET 7....

[pjanotti]

This is kind of ironic but hits the problem with the VBCSCompiler as intended, see https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/actions/runs/4110389057/jobs/7093155343#step:5:4366 and here for the explanation.

[pellared]

Regarding my prev. comment... I have not noticed that it is a PR 🤦

[pjanotti]

Adding the missing probe path while building the shared store, per this comment, fixed the issue locally.

[pjanotti]

Oh yeah forgot to update the test with the images...

[rajkumar-rangaraj]

Should we keep both current and roll-forward version?
I think removing the current version should not cause an issue.

Current
/store/x64/net6.0/microsoft.extensions.configuration.abstractions/7.0.0/lib/net6.0/Microsoft.Extensions.Configuration.Abstractions.dll

Roll-Forward
/store/x64/net6.0/microsoft.extensions.configuration.abstractions/7.0.0/lib/net7.0/Microsoft.Extensions.Configuration.Abstractions.dll

[pjanotti]

Should we keep both current and roll-forward version?

That's a good point. I did a quick test and as long as the additional deps.json is correctly updated I didn't see any issues instrumenting net6.0 applications even without explicitly setting roll-forward. However, I couldn't quickly get the additional deps file to be generated correctly (it needs to have lib/net7.0/ instead of lib/net6.0/). I will open a separate issue to handle that.

[pjanotti]

@otel-telemetry/dotnet-instrumentation-approvers

• Description was updated to better reflect the changes and why they are desired.
• Opened Optimize the roll-forward on AdditionalDeps and SharedStore #2180 to follow-up on Raj's suggestion to reduce the size of the shared store.

[pellared]

Suggested change

	private void RunAppWithDotNetCliAndAssertHttpSpans(string arguments)
	private void TestDotNetCli(string arguments)

IMO it would be more clear 😉

[pjanotti]

Hum, this one I like the long name: we are "testing" every execution of dotnet CLI the one with the long method name is different in that we want to run the actual application and check for the HTTP spans.