Install netfx dlls to GAC for tests

[RassK]

Why

Fixes #2155

What

Installs tracer-home/netfx dlls to GAC before running integration tests.

Tests

Existing.

Checklist

• New features are covered by tests.

[pjanotti]

@RassK What do you think about providing an uninstall target? It seems useful during development. While we don't need it in CI it helps keep the dev box clean.

[RassK]

@RassK What do you think about providing an uninstall target? It seems useful during development. While we don't need it in CI it helps keep the dev box clean.

I really wanted to implement it but I think it's not that straightforward. I'm a bit afraid to remove something that overlaps and breaks other applications. To fix that I would need to save a state that tracks what's new and could be removed... although even this is valid only short time.

[Kielek]

I think that we should update documentation that instrumenting .NET Fx stuff on Windows requires GAC update (done by psm1 file).
I do not think that it is obvious https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/docs/README.md?plain=1#L79-L211

[Kielek]

If I execute nuke or nuke Workflow with elevated privileges it will overwrite GAC,
It will be great to have reverse step included into it, or at least provide easy way to remove all this files.

I think nuke Workflow CleanupGAC execution form is fine.

[pellared]

I would prefer to have it as part of nuke or nuke Workflow

[RassK]

There are 2 ways which might work according to your own risk.

1. Add CleanupGAC to the workflow and a warning to use it on your own risk or skip the step.
2. Add CleanupGAC as a non referenced step. You need to run it yourself manually.

[pellared]

Probably point 2 is better/safer after all you said 😉
Make it could somehow part of nuke Cleanup?

[RassK]

Added UninstallNetFxAssembliesGAC also.
Clean is unfortunately way too early, tracer-home may not be present or in an outdated state.

[pellared]

I really wanted to implement it but I think it's not that straightforward. I'm a bit afraid to remove something that overlaps and breaks other applications. To fix that I would need to save a state that tracks what's new and could be removed... although even this is valid only short time.

@pjanotti was testing it and it will not remove the assemblies from GAC that were added by MSIs. See #1906 (comment)

[RassK]

I really wanted to implement it but I think it's not that straightforward. I'm a bit afraid to remove something that overlaps and breaks other applications. To fix that I would need to save a state that tracks what's new and could be removed... although even this is valid only short time.

@pjanotti was testing it and it will not remove the assemblies from GAC that were added by MSIs. See #1906 (comment)

Unfortunately there is no knowledge how different libs were added. It might work for CI or isolated work environment but general development machines (used for multiple projects) could be affected by removal.