-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document app.config limitation #2070
Conversation
- `OTEL_DOTNET_AUTO_HOME` | ||
- `OTEL_DOTNET_AUTO_EXCLUDE_PROCESSES` | ||
- `OTEL_DOTNET_AUTO_INTEGRATIONS_FILE` | ||
- `OTEL_DOTNET_AUTO_[TRACES|METRICS|LOGS]_[ENABLED|DISABLED]_INSTRUMENTATIONS` | ||
- `OTEL_DOTNET_AUTO_LOG_DIRECTORY` | ||
- `OTEL_DOTNET_AUTO_DEBUG` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might require some extra work, but I'm thinking now of re-doing the settings tables so that they have the following columns:
- Setting (env var)
- App.config / Web.config supported
- Description
- Default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep as it is for this PR (it makes also reviewing easier)? We can change the formatting/structure it in a separate PR.
@pellared Perhaps we can be more prescriptive as to when a method should be used instead of another? If there's choice, that is. Of course one can use env vars for everything, but when should they use |
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with very small comments
Co-authored-by: Zach Montoya <zach.montoya@datadoghq.com>
Why
Fixes #1429
After discussion with @andrewlock and @Kielek we decided that it is safer and probably good enough NOT to support all configuration via env vars. The main problem are the configuration read by the .NET Profiler which does not know anything about app.config. We could try "refreshing" the native configuration after the managed layer has loaded the app.config. However, that would probably require PInvoke and additional synchronization. Still this might result in race conditions.
Moreover, that env vars are per-process, but web.config can be per-appdomain; e.g.
Profiler doesn't know what to think
Essentially you'd have to check the appdomain for each callback, and some parts of the profiler are agnostic to that
So things will get complicated quickly.
At last this functionality would hopefully be not needed for the "happy path". The usual scenario would be use the app config to set the service name and other resource attributes, configure the exporter(s).
What
Document
app.config
andweb.config
limitation.Tests
Manually by modyfing integration tests and test applications
Checklist
CHANGELOG.md
is updated.New features are covered by tests.