Refactor Configuration namespace #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not merge until @RassK reviews it. |
RassK
reviewed
Jan 23, 2023
RassK
approved these changes
Jan 23, 2023
Kielek
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #1728
What
CompositeConfigurationSourcetoConfigurationwhich does not implementIConfigurationSource. This way we make sure thatSettingsclasses are for sure that empty string is handled as if there was no value. It is a similar design toLoggerandLogSink.Settingsto haveabstractmethod instead of logic inside constructor. Thanks to it we can get rid of reflection inSettingsclass.Tests
GetInt32,GetDouble,GetBool. I think I will add then in next PR.