Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests shell script with CI artifacts #1703

Merged
merged 20 commits into from
Dec 6, 2022

Conversation

dszmigielski
Copy link
Contributor

@dszmigielski dszmigielski commented Dec 2, 2022

Why

Fixes #1604

What

Move instrument.sh script tests to base build pipeline. Test on artifacts created by build instead of the release ones. Move installation script testing to release pipeline.

Tests

CI, publishing release tested on fork:
https://github.com/dszmigielski/opentelemetry-dotnet-instrumentation/actions/runs/3628401439

Checklist

- [ ] CHANGELOG.md is updated.
- [ ] Documentation is updated.
- [ ] New features are covered by tests.

@dszmigielski dszmigielski changed the title Test on smoke tests app; separate install script testing from instrum… Tests shell script with CI artifacts Dec 2, 2022
@dszmigielski dszmigielski marked this pull request as ready for review December 5, 2022 07:46
@dszmigielski dszmigielski requested a review from a team December 5, 2022 07:46
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
dszmigielski and others added 2 commits December 5, 2022 09:06
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@dszmigielski dszmigielski marked this pull request as draft December 5, 2022 08:26
.github/workflows/script-tests.yml Outdated Show resolved Hide resolved
.github/workflows/script-tests.yml Outdated Show resolved Hide resolved
.github/workflows/script-tests.yml Outdated Show resolved Hide resolved
@dszmigielski dszmigielski marked this pull request as ready for review December 6, 2022 09:55
@dszmigielski dszmigielski requested a review from Kielek December 6, 2022 09:57
@dszmigielski dszmigielski requested review from pellared and Kielek and removed request for Kielek and pellared December 6, 2022 09:57
@pellared pellared merged commit 8c6ed3a into open-telemetry:main Dec 6, 2022
@dszmigielski dszmigielski deleted the fix-script-test branch December 6, 2022 12:11
@Kielek Kielek mentioned this pull request Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests shell script with CI artifacts
3 participants