-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calulate default OS_TYPE #1403
Calulate default OS_TYPE #1403
Conversation
I want to merge #1402 first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but, as a know-very-little-bash-script person I have to ask: is it worth to put the code to select the OS type in a shareable way? Likely not worth the trouble but I have to ask 😬
I have no idea how to do it (and I was considering it 😅 )
Side note:
😸 |
Why
Better UX. No need to provide
OS_TYPE
Part of #1373
What
Calculate
OS_TYPE
usinguname -s
andldd /bin/ls
Tests
CI and locally
Checklist
CHANGELOG.md
is updated.Documentation is updated.