Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calulate default OS_TYPE #1403

Merged
merged 8 commits into from
Oct 12, 2022
Merged

Conversation

pellared
Copy link
Member

@pellared pellared commented Oct 11, 2022

Why

Better UX. No need to provide OS_TYPE

Part of #1373

What

Calculate OS_TYPE using uname -s and ldd /bin/ls

Tests

CI and locally

Checklist

  • CHANGELOG.md is updated.
  • Documentation is updated.
  • New features are covered by tests.

@pellared pellared requested a review from a team October 11, 2022 09:45
@github-actions github-actions bot requested a review from theletterf October 11, 2022 09:45
@pellared
Copy link
Member Author

I want to merge #1402 first

Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but, as a know-very-little-bash-script person I have to ask: is it worth to put the code to select the OS type in a shareable way? Likely not worth the trouble but I have to ask 😬

@pellared
Copy link
Member Author

pellared commented Oct 12, 2022

is it worth to put the code to select the OS type in a shareable way

I have no idea how to do it (and I was considering it 😅 )

  1. download.sh is the "first" script that the user downloads to setup. the instrument.sh is not available until it is extracted
  2. I assume that once the user downloads (installs) then he/she only needs instrument.sh and download.sh is no longer needed (also getting the path to download.sh would be probably close to impossible)

Side note:

"A little copying is better than a little dependency. "

😸

@pellared pellared enabled auto-merge (squash) October 12, 2022 05:28
@pellared pellared merged commit 75f27c4 into open-telemetry:main Oct 12, 2022
@pellared pellared deleted the guess-os-type branch October 12, 2022 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants