Change INSTALL_DIR to OTEL_DOTNET_AUTO_HOME in scripts #1375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Part of #1373
OTEL_DOTNET_AUTO_HOME
so thatINSTALL_DIR
(which is not a unique name) does not have to be provided when a custom installation path is usedinstall.sh
could even set OTEL_DOTNET_AUTO_HOME as a global env var to facilitate using./instrument.sh
. Not now for sure - personally I want to postpone setting global env vars until we see that it is beneficial)Also, change the default so that, by default, the
./instrument.sh
could be used from a different location.What
INSTALL_DIR
env var script param toOTEL_DOTNET_AUTO_HOME
$HOME/.otel-auto-dotnet
dotnet-install.sh
$PWD
RELEASES_URL
script param (YAGNI)Tests
CI
Checklist
CHANGELOG.md
is updated.