Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.Geneva] Fix exemplar value serialization for TLV serialization format #1698

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Apr 26, 2024

Fixes #.

Changes

Fixes serialization to look up the appropriate value type based on the metric type.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 62.92%. Comparing base (71655ce) to head (f141fb4).
Report is 222 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1698       +/-   ##
===========================================
- Coverage   73.91%   62.92%   -11.00%     
===========================================
  Files         267       35      -232     
  Lines        9615     3482     -6133     
===========================================
- Hits         7107     2191     -4916     
+ Misses       2508     1291     -1217     
Flag Coverage Δ
unittests-Exporter.Geneva 62.92% <61.53%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...metry.Exporter.Geneva/Metrics/TlvMetricExporter.cs 71.17% <61.53%> (ø)

... and 249 files with indirect coverage changes

@vishweshbankwar vishweshbankwar marked this pull request as ready for review April 26, 2024 22:16
@vishweshbankwar vishweshbankwar requested a review from a team April 26, 2024 22:16
@vishweshbankwar vishweshbankwar added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Apr 26, 2024
@vishweshbankwar vishweshbankwar merged commit 9d4b5f1 into open-telemetry:main Apr 26, 2024
36 checks passed
@vishweshbankwar
Copy link
Member Author

Received approval from component owner for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants