featureflagservice: expose grpc service on port FEATURE_FLAG_GRPC_SERVICE_PORT #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mic-max
approved these changes
Aug 2, 2022
|
@tsloughter If you plan on testing the featureflag service, could you add it to |
julianocosta89
approved these changes
Aug 3, 2022
fatsheep9146
approved these changes
Aug 3, 2022
|
@mic-max I wasn't planning on adding tests, I just meant for manual testing purposes. But I can plan to add some in test.js eventually. |
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
…VICE_PORT (open-telemetry#250) Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to use the featureflag service from outside of the docker-compose network with like grpcurl for testing.