-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontendproxy] - add envoy access logs #1768
[frontendproxy] - add envoy access logs #1768
Conversation
Co-authored-by: Cedric Ziel <cedric@cedric-ziel.com>
@puckpuck are you also seeing the error I mentioned above? |
It took me a while to figure this one out, but it seems like the log volume and log size is too big for the Grafana <-> OpenSearch exchange. I found other minor issues and optimizations as well, but will ultimately impose a limit on the # of entries that are returned to that log panel. I may settle on 100 entries since this is meant to be a demo (and update the panel title accordingly as well). I'll update this PR later today with the fixes. |
@julianocosta89 can you try again now? |
@puckpuck not getting the error, but not getting any log for I've noticed some error messages on the collector:
|
Can you recheck your configuration including
|
@puckpuck added some nitty picks in here fd2da2f, hope you don't mind. The I've changed the query to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Also, thx @martinjt!
One thing that I missed was the log level, but couldn't find a way to have that in Envoy |
Changes
Supersedes #1751
This adds Envoy access logs to the OTLP logs pipeline. Semantic conventions were followed as much as possible for the various attributes added.
Merge Requirements
For new feature contributions, please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.