Fix CMake 3.20 warning in curl http client #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix CMake 3.20+ warning
Codecov Report
@@ Coverage Diff @@
## main #752 +/- ##
==========================================
+ Coverage 95.95% 95.97% +0.01%
==========================================
Files 174 174
Lines 7127 7127
==========================================
+ Hits 6839 6840 +1
+ Misses 288 287 -1
|
ThomsonTan
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up build warning. No code changes.
Fix CMake 3.20+ warning. If you are building with fresh CMake that comes in latest Visual Studio 2019 update, then it complains about filenames in
CMakeLists.txtnot having extensions. This is happening due to new policy CMP0115 described here -Source file extensions must be explicit.. This logically makes sense when target library name matches that one of a source file name, to clearly disambiguate between the two: what is target name, and what is source file name.