Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Context::HasKey const #671

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

eyjohn
Copy link
Contributor

@eyjohn eyjohn commented Apr 11, 2021

Fixes #670

Changes

  • Update Context::HasKey to be const
  • Add const qualifier in tests for HasKey, GetValue to validate constness
  • Unit tests have been updated

- Update `Context::HasKey` to be const
- Add const qualifier to HasKey,GetValue to validate constness
@eyjohn eyjohn requested a review from a team April 11, 2021 10:46
@codecov
Copy link

codecov bot commented Apr 11, 2021

Codecov Report

Merging #671 (25f056f) into main (9a99b97) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
+ Coverage   94.65%   94.66%   +0.01%     
==========================================
  Files         204      204              
  Lines        9387     9387              
==========================================
+ Hits         8885     8886       +1     
+ Misses        502      501       -1     
Impacted Files Coverage Δ
api/include/opentelemetry/context/context.h 100.00% <100.00%> (ø)
api/test/context/context_test.cc 98.76% <100.00%> (ø)
sdk/src/logs/batch_log_processor.cc 95.00% <0.00%> (+1.25%) ⬆️

@lalitb lalitb merged commit d129d42 into open-telemetry:main Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context::HasKey missing const qualifier
2 participants