Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename HTTPTextFormat to TextMapPropagator #586

Merged
merged 3 commits into from
Feb 23, 2021

Conversation

TomRoSystems
Copy link
Member

Fixes #536

Changes

As per spec open-telemetry/opentelemetry-specification#793

Trivial change.

@TomRoSystems TomRoSystems requested a review from a team February 23, 2021 00:06
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #586 (d39a761) into main (4be5a94) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #586      +/-   ##
==========================================
- Coverage   94.41%   94.40%   -0.02%     
==========================================
  Files         200      200              
  Lines        9068     9068              
==========================================
- Hits         8562     8561       -1     
- Misses        506      507       +1     
Impacted Files Coverage Δ
...de/opentelemetry/trace/propagation/b3_propagator.h 97.95% <ø> (ø)
...entelemetry/trace/propagation/http_trace_context.h 86.79% <ø> (ø)
api/test/trace/propagation/b3_propagation_test.cc 100.00% <ø> (ø)
...pi/test/trace/propagation/http_text_format_test.cc 98.30% <100.00%> (ø)
sdk/test/metrics/counter_aggregator_test.cc 98.21% <0.00%> (-1.79%) ⬇️
sdk/src/logs/batch_log_processor.cc 93.82% <0.00%> (-1.24%) ⬇️
sdk/test/common/circular_buffer_test.cc 100.00% <0.00%> (+1.04%) ⬆️

@lalitb
Copy link
Member

lalitb commented Feb 23, 2021

Thanks for the fix.

@lalitb lalitb merged commit 7ae5b54 into open-telemetry:main Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename HTTPTextFormat to TextMapPropagator
3 participants