Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Logging SDK Context Injection and Logger Limit #435

Closed
wants to merge 2 commits into from

Conversation

MarkSeufert
Copy link
Contributor

@MarkSeufert MarkSeufert commented Dec 9, 2020

Note: This PR is going to be updated once the recordable PR gets merged.

This PR makes the following additions to the logging SDK:

  • The SDK’s Logger injects the relevant fields of the LogRecord if the user didn’t specify them. The fields that get injected are timestamp, severity, traceid, spanid, and traceflags.
  • Added a logger limit to the SDK LoggerProvider (relevant spec issue), where the GetLogger(name) method returns a noop logger if the limit has been reached.
  • Unit tests for the above functionality.

The CI tests will fail until the recent API PR gets merged since it uses its trace_flag -> trace_flags change and Severity:kInvalid = 0 change.

cc - @xukaren @alolita @ThomsonTan @lalitb

@MarkSeufert
Copy link
Contributor Author

Closing this PR for now so the more pressing logging PRs (recordable, ostream exporter, batch log processor) can be reviewed before reopening this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant