Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl based implementation for http client api #385

Merged
merged 34 commits into from
Nov 18, 2020

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Nov 3, 2020

This brings the CURL implementation for HTTP Client API, along with few minor changes in API.

TODO -

@lalitb lalitb requested a review from a team November 3, 2020 20:56
@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #385 (2568485) into master (88d43a3) will decrease coverage by 0.29%.
The diff coverage is 89.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
- Coverage   95.00%   94.71%   -0.30%     
==========================================
  Files         171      175       +4     
  Lines        7186     7581     +395     
==========================================
+ Hits         6827     7180     +353     
- Misses        359      401      +42     
Impacted Files Coverage Δ
...nclude/opentelemetry/ext/http/client/http_client.h 90.90% <ø> (ø)
...lemetry/ext/http/client/curl/http_operation_curl.h 82.43% <82.43%> (ø)
ext/test/http/curl_http_test.cc 93.50% <93.50%> (ø)
...ntelemetry/ext/http/client/curl/http_client_curl.h 95.00% <95.00%> (ø)
sdk/test/metrics/counter_aggregator_test.cc 98.21% <0.00%> (-1.79%) ⬇️
sdk/test/common/circular_buffer_test.cc 98.97% <0.00%> (-1.03%) ⬇️
... and 2 more

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

lalitb and others added 3 commits November 10, 2020 10:10
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine for CURL, but I have a few asks:

  • Can you open a ticket about Bazel support and assign to me? I'll look into it.
  • Can you update documentation for how to compile w/ CURL support (with a TODO on bazel). I think adding optional deps like these really need to be well documented on how to consume them, and what level of support they have.

Copy link
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this on the way. I added some suggestions and questions about points that are unclear to me.

@lalitb
Copy link
Member Author

lalitb commented Nov 12, 2020

This looks fine for CURL, but I have a few asks:

  • Can you open a ticket about Bazel support and assign to me? I'll look into it.
  • Can you update documentation for how to compile w/ CURL support (with a TODO on bazel). I think adding optional deps like these really need to be well documented on how to consume them, and what level of support they have.

Appreciate your help here @jsuereth . I have created the ticket #390 for bazel build, and assigned to you. Please feel free to take it up once this PR is merged. I will add documentation for this dependency, though I have mentioned few details in new ticket which will help you get going.

@lalitb
Copy link
Member Author

lalitb commented Nov 13, 2020

Need to remove http_server from code coverage . It seems to be affecting the overall percentage.

@lalitb
Copy link
Member Author

lalitb commented Nov 18, 2020

@reyang - We discussed this PR during community meeting. It should be fine to merge it. There is tiny drop in code coverage percentage I believe it should be acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants