Skip to content

Commit

Permalink
Fix formatting
Browse files Browse the repository at this point in the history
Signed-off-by: Harish Shan <140232061+perhapsmaple@users.noreply.github.com>
  • Loading branch information
perhapsmaple committed Oct 31, 2023
1 parent 1f9ac98 commit f34c06c
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ class InstrumentSelector
{
public:
InstrumentSelector(opentelemetry::sdk::metrics::InstrumentType instrument_type,
const std::string& name,
const std::string& units)
const std::string &name,
const std::string &units)
: name_filter_{PredicateFactory::GetPredicate(name, PredicateType::kPattern)},
unit_filter_{PredicateFactory::GetPredicate(units, PredicateType::kExact)},
instrument_type_{instrument_type}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ class OPENTELEMETRY_EXPORT InstrumentSelectorFactory
public:
static std::unique_ptr<InstrumentSelector> Create(
opentelemetry::sdk::metrics::InstrumentType instrument_type,
const std::string& name,
const std::string& unit);
const std::string &name,
const std::string &unit);
};

} // namespace metrics
Expand Down
4 changes: 1 addition & 3 deletions sdk/include/opentelemetry/sdk/metrics/view/meter_selector.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ namespace metrics
class MeterSelector
{
public:
MeterSelector(const std::string& name,
const std::string& version,
const std::string& schema)
MeterSelector(const std::string &name, const std::string &version, const std::string &schema)
: name_filter_{PredicateFactory::GetPredicate(name, PredicateType::kExact)},
version_filter_{PredicateFactory::GetPredicate(version, PredicateType::kExact)},
schema_filter_{PredicateFactory::GetPredicate(schema, PredicateType::kExact)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ class MeterSelector;
class OPENTELEMETRY_EXPORT MeterSelectorFactory
{
public:
static std::unique_ptr<MeterSelector> Create(const std::string& name,
const std::string& version,
const std::string& schema);
static std::unique_ptr<MeterSelector> Create(const std::string &name,
const std::string &version,
const std::string &schema);
};

} // namespace metrics
Expand Down
4 changes: 2 additions & 2 deletions sdk/src/metrics/view/instrument_selector_factory.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ namespace metrics

std::unique_ptr<InstrumentSelector> InstrumentSelectorFactory::Create(
opentelemetry::sdk::metrics::InstrumentType instrument_type,
const std::string& name,
const std::string& unit)
const std::string &name,
const std::string &unit)
{
std::unique_ptr<InstrumentSelector> instrument_selector(
new InstrumentSelector(instrument_type, name, unit));
Expand Down
7 changes: 3 additions & 4 deletions sdk/src/metrics/view/meter_selector_factory.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,9 @@ namespace sdk
namespace metrics
{

std::unique_ptr<MeterSelector> MeterSelectorFactory::Create(
const std::string& name,
const std::string& version,
const std::string& schema)
std::unique_ptr<MeterSelector> MeterSelectorFactory::Create(const std::string &name,
const std::string &version,
const std::string &schema)
{
std::unique_ptr<MeterSelector> meter_selector(new MeterSelector(name, version, schema));
return meter_selector;
Expand Down

0 comments on commit f34c06c

Please sign in to comment.