removed tracer from all span classes

open-telemetry · Aug 19, 2020 · c5164c9 · c5164c9
1 parent 466d4f3
commit c5164c9
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 39 deletions.
diff --git a/api/include/opentelemetry/trace/noop.h b/api/include/opentelemetry/trace/noop.h
@@ -49,7 +49,6 @@ class NoopSpan final : public Span
   bool IsRecording() const noexcept override { return false; }
 
   SpanContext GetContext() const noexcept override { return span_context_; }
-  //  Tracer &tracer() const noexcept override { return *tracer_; }
 
   void SetToken(nostd::unique_ptr<context::Token> && /* token */) noexcept override {}
 

diff --git a/api/include/opentelemetry/trace/span.h b/api/include/opentelemetry/trace/span.h
@@ -162,9 +162,6 @@ class Span
   // AddEvent).
   virtual bool IsRecording() const noexcept = 0;
 
-  // Cannot have Tracer in Span right now because it will cause cyclical dependency issue
-  // virtual Tracer &tracer() const noexcept = 0;
-
   virtual void SetToken(nostd::unique_ptr<context::Token> &&token) noexcept = 0;
 };
 }  // namespace trace

diff --git a/api/test/trace/CMakeLists.txt b/api/test/trace/CMakeLists.txt
@@ -1,7 +1,6 @@
 foreach(
   testname
   key_value_iterable_view_test
-  noop_test
   provider_test
   span_id_test
   trace_id_test

diff --git a/api/test/trace/noop_test.cc b/api/test/trace/noop_test.cc
diff --git a/examples/plugin/plugin/tracer.cc b/examples/plugin/plugin/tracer.cc
@@ -53,7 +53,6 @@ class Span final : public trace::Span
   bool IsRecording() const noexcept override { return true; }
 
   trace::SpanContext GetContext() const noexcept override { return span_context_; }
-  //  Tracer &tracer() const noexcept override { return *tracer_; }
 
   void SetToken(nostd::unique_ptr<context::Token> &&token) noexcept override {}
 

diff --git a/sdk/src/trace/span.h b/sdk/src/trace/span.h
@@ -43,7 +43,6 @@ class Span final : public trace_api::Span
   bool IsRecording() const noexcept override;
 
   trace_api::SpanContext GetContext() const noexcept override { return trace_api::SpanContext(); }
-  //  trace_api::Tracer &tracer() const noexcept override { return *tracer_; }
 
   void SetToken(nostd::unique_ptr<context::Token> &&token) noexcept override;