Apply suggestions from code review

open-telemetry · Nov 24, 2024 · 9db948d · 9db948d
1 parent d160f8a
commit 9db948d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/sdk/include/opentelemetry/sdk/trace/span_data.h b/sdk/include/opentelemetry/sdk/trace/span_data.h
@@ -254,8 +254,10 @@ class SpanData final : public Recordable
   }
 
   void AddEvent(nostd::string_view name,
-                opentelemetry::common::SystemTimestamp timestamp,
-                const opentelemetry::common::KeyValueIterable &attributes) noexcept override
+                opentelemetry::common::SystemTimestamp timestamp =
+                    opentelemetry::common::SystemTimestamp(std::chrono::system_clock::now()),
+                const opentelemetry::common::KeyValueIterable &attributes =
+                    opentelemetry::common::KeyValueIterableView<std::map<std::string, int32_t>>) noexcept override
   {
     SpanDataEvent event(std::string(name), timestamp, attributes);
     events_.push_back(event);

diff --git a/sdk/test/trace/span_data_test.cc b/sdk/test/trace/span_data_test.cc
@@ -69,8 +69,7 @@ TEST(SpanData, Set)
   data.SetStartTime(now);
   data.SetDuration(std::chrono::nanoseconds(1000000));
   data.SetAttribute("attr1", static_cast<int64_t>(314159));
-  data.AddEvent("event1", now,
-                opentelemetry::common::KeyValueIterableView<std::map<std::string, int32_t>>({}));
+  data.AddEvent("event1", now);
 
   ASSERT_EQ(data.GetTraceId(), trace_id);
   ASSERT_EQ(data.GetSpanId(), span_id);