Skip to content

Commit

Permalink
[BUILD] Remove the hard-coded separator in tracestate (#2672)
Browse files Browse the repository at this point in the history
  • Loading branch information
ThomsonTan authored May 23, 2024
1 parent 9c767df commit 78d488c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion api/include/opentelemetry/trace/trace_state.h
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ class OPENTELEMETRY_EXPORT TraceState
[&header_s, &first](nostd::string_view key, nostd::string_view value) noexcept {
if (!first)
{
header_s.append(",");
header_s.append(1, kMembersSeparator);
}
else
{
Expand Down

1 comment on commit 78d488c

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 78d488c Previous: 9c767df Ratio
BM_BaselineBuffer/2 7423226.833343506 ns/iter 2640460.594071036 ns/iter 2.81

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.