review comments

open-telemetry · Jan 22, 2025 · 03efcb5 · 03efcb5
1 parent 8f60276
commit 03efcb5
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/sdk/src/metrics/state/temporal_metric_storage.cc b/sdk/src/metrics/state/temporal_metric_storage.cc
@@ -51,15 +51,15 @@ bool TemporalMetricStorage::buildMetrics(CollectorHandle *collector,
   AggregationTemporality aggregation_temporarily =
       collector->GetAggregationTemporality(instrument_descriptor_.type_);
 
+  // If no metrics, early return
+  if (delta_metrics->Size() == 0)
+  {
+    return true;
+  }
+
   // Fast path for single collector with delta temporality and counter, updown-counter, histogram
-  if (collectors.size() == 1 && collector->GetAggregationTemporality(
-                                    instrument_descriptor_.type_) == AggregationTemporality::kDelta)
+  if (collectors.size() == 1 && aggregation_temporarily == AggregationTemporality::kDelta)
   {
-    // If no metrics, early return
-    if (delta_metrics->Size() == 0)
-    {
-      return true;
-    }
 
     // Create MetricData directly
     MetricData metric_data;