Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CODEOWNERS #12

Merged
merged 7 commits into from
Apr 1, 2021
Merged

Create CODEOWNERS #12

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6216af5
add codeowners
lalitb Mar 30, 2021
0fbaaaa
fix readme
lalitb Mar 30, 2021
20f5559
add individual approvers
lalitb Mar 30, 2021
f9dfd6b
revert readme
lalitb Mar 30, 2021
b6989a8
fix codeowners
lalitb Mar 30, 2021
284c1ac
add group
lalitb Mar 31, 2021
a944835
fix codeowners
lalitb Mar 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Code owners file.
# This file controls who is tagged for review for any given pull request.

# Learn about CODEOWNERS file format:
# https://help.github.com/en/articles/about-code-owners
#

* @ThomsonTan @seemk @TomRoSystems @jsuereth @maxgolov @lalitb @pyohannes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add something like @open-telemetry/cpp-contrib-approvers?

Copy link
Member Author

@lalitb lalitb Mar 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have this team for now. I will raise request to create one for this repo. Meanwhile we can discuss in this PR if all in the list agree to be there :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added this group now.