-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move internal/testdata to pdata/testdata #9885
move internal/testdata to pdata/testdata #9885
Conversation
These are not needed by the module, unsure why crosslink thinks they're needed. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9885 +/- ##
=======================================
Coverage 91.31% 91.31%
=======================================
Files 357 357
Lines 19202 19202
=======================================
Hits 17534 17534
Misses 1340 1340
Partials 328 328 ☔ View full report in Codecov by Sentry. |
This reduces dependencies from the consumer package while making testdata available across repos. It will allow us to remove duplicated code and its a fairly small surface area. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to be perma-unstable? If so, I would vote to have a different versioning schema like 0.0.x
(I suggested that on #9209 (comment) but I haven't followed up on it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I expect this package to become eventually stable though. There is no particular reason to not have it stable that I can think of.
@mx-psi it could definitely be marked as stable, i just didn't know if it's something we would care to do. There isn't a large surface area, but since its mostly used for tests I wasn't sure if we want to make guarantees about its stability |
I wouldn't mind getting this to 1.x, it wouldn't be too bad to get a 2.x of this module if we ever need to, given there will be no non-test dependencies |
This reduces dependencies from the consumer package while making testdata available across repos. It will allow us to remove duplicated code and its a fairly small surface area.
Fixes #9886