Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move internal/testdata to pdata/testdata #9885

Merged
merged 9 commits into from
Apr 8, 2024

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Apr 3, 2024

This reduces dependencies from the consumer package while making testdata available across repos. It will allow us to remove duplicated code and its a fairly small surface area.

Fixes #9886

These are not needed by the module, unsure why crosslink thinks they're needed.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested review from a team and dmitryax April 3, 2024 15:30
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.31%. Comparing base (79ccf55) to head (9712e96).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9885   +/-   ##
=======================================
  Coverage   91.31%   91.31%           
=======================================
  Files         357      357           
  Lines       19202    19202           
=======================================
  Hits        17534    17534           
  Misses       1340     1340           
  Partials      328      328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This reduces dependencies from the consumer package while making testdata available across repos. It will allow us to remove duplicated code and its a fairly small surface area.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten marked this pull request as draft April 3, 2024 19:16
@codeboten codeboten changed the title [chore] cleanup unnecessary replace move internal/testdata to pdata/testdata Apr 3, 2024
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to be perma-unstable? If so, I would vote to have a different versioning schema like 0.0.x (I suggested that on #9209 (comment) but I haven't followed up on it)

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I expect this package to become eventually stable though. There is no particular reason to not have it stable that I can think of.

@codeboten
Copy link
Contributor Author

@mx-psi it could definitely be marked as stable, i just didn't know if it's something we would care to do. There isn't a large surface area, but since its mostly used for tests I wasn't sure if we want to make guarantees about its stability

@mx-psi
Copy link
Member

mx-psi commented Apr 5, 2024

@mx-psi it could definitely be marked as stable, i just didn't know if it's something we would care to do. There isn't a large surface area, but since its mostly used for tests I wasn't sure if we want to make guarantees about its stability

I wouldn't mind getting this to 1.x, it wouldn't be too bad to get a 2.x of this module if we ever need to, given there will be no non-test dependencies

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten marked this pull request as ready for review April 5, 2024 18:15
@codeboten codeboten merged commit fc28929 into open-telemetry:main Apr 8, 2024
42 of 57 checks passed
@codeboten codeboten deleted the codeboten/cleanup-gomod branch April 8, 2024 15:37
@github-actions github-actions bot added this to the next release milestone Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make collector/internal/testdata available as a public utility package
3 participants