Generate "Golden Data" trace spans #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #967 +/- ##
==========================================
+ Coverage 85.61% 86.06% +0.44%
==========================================
Files 189 193 +4
Lines 13167 13749 +582
==========================================
+ Hits 11273 11833 +560
- Misses 1441 1455 +14
- Partials 453 461 +8
Continue to review full report at Codecov.
|
| @@ -0,0 +1,289 @@ | |||
| Parent Tracestate Kind Attributes Events Links Status | |||
There was a problem hiding this comment.
Is this a generated file? Can we have generated in the name and document how it is generated/can be regenerated?
There was a problem hiding this comment.
Changed file names to start with generated. I plan to do documentation after the entire solution is coded and I have chance to play around with the best approach for making changes and automating it all.
bogdandrutu
reviewed
May 14, 2020
bogdandrutu
reviewed
May 16, 2020
|
@kbrockhoff please fix the conflicts. |
tigrannajaryan
approved these changes
May 21, 2020
|
Made two changes:
|
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
1. PICT tool input files for trace data and resulting output files from running pict from the command line. These are in `internal/goldendataset/testdata`. See: [Pairwise Independent Combinatorial Testing](https://github.com/microsoft/pict) 2. Generator for fully-populated OLTP ResourceSpans from PICT output files. This has all the intended functionality for this PR. It has no impact on other functionality so there should be no problem in merging to master. I will follow up with other PRs to complete full "Golden Dataset" testing functionality. **Link to tracking Issue:** open-telemetry#652 **Testing:** Unit tests exist for all functionality which has been coded so far **Documentation:** None yet. Will do so after golden dataset generation coding is complete.
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
* Add k8s infra monitorig demo example Signed-off-by: ChrsMark <chrismarkou92@gmail.com> * Upgrade chart version Signed-off-by: ChrsMark <chrismarkou92@gmail.com> * Bump patch version instead of minor Signed-off-by: ChrsMark <chrismarkou92@gmail.com> --------- Signed-off-by: ChrsMark <chrismarkou92@gmail.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This pull request has two items:
internal/goldendataset/testdata. See: Pairwise Independent Combinatorial TestingThis has all the intended functionality for this PR. It has no impact on other functionality so there should be no problem in merging to master. I will follow up with other PRs to complete full "Golden Dataset" testing functionality.
Link to tracking Issue: #652
Testing: Unit tests exist for all functionality which has been coded so far
Documentation: None yet. Will do so after golden dataset generation coding is complete.