[otlpexporter] Validate the configuration explicitly #9523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9523 +/- ##
==========================================
+ Coverage 90.34% 90.40% +0.05%
==========================================
Files 346 347 +1
Lines 18194 18187 -7
==========================================
+ Hits 16438 16442 +4
+ Misses 1422 1414 -8
+ Partials 334 331 -3 ☔ View full report in Codecov by Sentry. |
31a68ff to
6ea578c
Compare
|
Leaning towards no changelog since it feels like this is not a functional change, but please weigh in. |
bogdandrutu
reviewed
Feb 8, 2024
6ea578c to
8c84861
Compare
bogdandrutu
approved these changes
Feb 8, 2024
bogdandrutu
approved these changes
Feb 9, 2024
jpkrohling
added a commit
to jpkrohling/opentelemetry-collector-contrib
that referenced
this pull request
Feb 22, 2024
As part of open-telemetry/opentelemetry-collector#9523, the OTLP Exporter configuration used by the load balancing exporter is being validates automatically. However, the endpoint is the only thing users should NOT set, as it will be set at a later point in time by the load balancer. This PR sets a placeholder value for the endpoint so that the validation passes. Fixes open-telemetry#31371 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Feb 22, 2024
As part of open-telemetry/opentelemetry-collector#9523, the OTLP Exporter configuration used by the load balancing exporter is being validates automatically. However, the endpoint is the only thing users should NOT set, as it will be set at a later point in time by the load balancer. This PR sets a placeholder value for the endpoint so that the validation passes. Fixes #31371 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> --------- Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
added a commit
to jpkrohling/opentelemetry-collector-contrib
that referenced
this pull request
Feb 26, 2024
…1381) As part of open-telemetry/opentelemetry-collector#9523, the OTLP Exporter configuration used by the load balancing exporter is being validates automatically. However, the endpoint is the only thing users should NOT set, as it will be set at a later point in time by the load balancer. This PR sets a placeholder value for the endpoint so that the validation passes. Fixes open-telemetry#31371 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> --------- Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
This was referenced Feb 27, 2024
TylerHelmuth
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Feb 28, 2024
… unit test (#31425) **Description:** As described in the otel-collector [issue 9505](open-telemetry/opentelemetry-collector#9505), the otlpexporter does not function correctly if no port is defined. To resolve this, the otlp config validation has been updated to fail fast when the endpoint within an otlp config does not have a port specified. The loadbalancingexporter config has the otlp exporter config as a dependency, however, the loadbalancing exporter does not define a port on the otlpexporter config in two places: - default config from factory - testdata contents This is currently a blocker to the contrib tests for the [PR](open-telemetry/opentelemetry-collector#9632) to resolve issue 9505 Relates to: open-telemetry/opentelemetry-collector#9523 #31371 #31381 **Link to tracking Issue:** otel-collector-contrib: [issue 31426](#31426) Arises from otel-collector [issue 9505](open-telemetry/opentelemetry-collector#9505) **Testing:** Used `replace` to test loadbalancingexporter changes pass tests successfully when using the otlpexporter changes from [PR](open-telemetry/opentelemetry-collector#9632)
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…1381) As part of open-telemetry/opentelemetry-collector#9523, the OTLP Exporter configuration used by the load balancing exporter is being validates automatically. However, the endpoint is the only thing users should NOT set, as it will be set at a later point in time by the load balancer. This PR sets a placeholder value for the endpoint so that the validation passes. Fixes open-telemetry#31371 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> --------- Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
… unit test (open-telemetry#31425) **Description:** As described in the otel-collector [issue 9505](open-telemetry/opentelemetry-collector#9505), the otlpexporter does not function correctly if no port is defined. To resolve this, the otlp config validation has been updated to fail fast when the endpoint within an otlp config does not have a port specified. The loadbalancingexporter config has the otlp exporter config as a dependency, however, the loadbalancing exporter does not define a port on the otlpexporter config in two places: - default config from factory - testdata contents This is currently a blocker to the contrib tests for the [PR](open-telemetry/opentelemetry-collector#9632) to resolve issue 9505 Relates to: open-telemetry/opentelemetry-collector#9523 open-telemetry#31371 open-telemetry#31381 **Link to tracking Issue:** otel-collector-contrib: [issue 31426](open-telemetry#31426) Arises from otel-collector [issue 9505](open-telemetry/opentelemetry-collector#9505) **Testing:** Used `replace` to test loadbalancingexporter changes pass tests successfully when using the otlpexporter changes from [PR](open-telemetry/opentelemetry-collector#9632)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use
Config.Validateto validate the presence of the gRPC endpoint instead of making an assertion at creation time.