-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/nopreceiver] Add the nopreceiver #9446
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9446 +/- ##
==========================================
- Coverage 90.95% 90.93% -0.02%
==========================================
Files 350 352 +2
Lines 18576 18591 +15
==========================================
+ Hits 16895 16906 +11
- Misses 1354 1358 +4
Partials 327 327 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor CI issues aside
Edit: this fails another check, I had to change my approach. See below. |
f630092
to
3535e49
Compare
It looks like I need to leave in the |
41a89fb
to
bbacb14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! ❤️
f815130
to
d90934f
Compare
@evan-bradley ptal at the check failure |
1c9151c
to
f3af92c
Compare
@codeboten should be good now, thanks. The codecov check is still failing due to a lack of test coverage on generated code, but it looks like that's an optional check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please rebase and update the dependancies
f3af92c
to
3e2c65d
Compare
@dmitryax Thanks for taking a look. Should be good to go now. |
ee0a1af
to
7e7fa11
Compare
e5b9742
to
b99f69d
Compare
b99f69d
to
e4c3692
Compare
@dmitryax CI is green now, minus the code coverage failure due to the lack of tests for generated code. |
**Description:** Add the nopreceiver. This can be helpful if a user wants to start the Collector with a dummy pipeline to only enable extensions. It could also be used to start a dynamically-configured Collector that starts with no config and waits to receive its config from a confmap.Provider that supports reloads. **Link to tracking Issue:** Works toward open-telemetry#7316 **Testing:** Added lifecycle tests; the receiver doesn't do anything. **Documentation:** Added a readme for the component.
Description:
Add the nopreceiver. This can be helpful if a user wants to start the Collector with a dummy pipeline to only enable extensions. It could also be used to start a dynamically-configured Collector that starts with no config and waits to receive its config from a confmap.Provider that supports reloads.
Link to tracking Issue:
Works toward #7316
Testing:
Added lifecycle tests; the receiver doesn't do anything.
Documentation:
Added a readme for the component.