Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configcompression] Rename Enums to match standard #9417

Conversation

TylerHelmuth
Copy link
Member

Description:
If we choose to keep the name

Link to tracking Issue:
Related to #9388

@TylerHelmuth TylerHelmuth force-pushed the configcompression-rename-enum-2 branch from 46c5b39 to cb129c4 Compare January 29, 2024 21:47
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8b95295) 90.22% compared to head (cb129c4) 90.22%.

Files Patch % Lines
config/configcompression/compressiontype.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9417   +/-   ##
=======================================
  Coverage   90.22%   90.22%           
=======================================
  Files         345      345           
  Lines       18019    18019           
=======================================
  Hits        16257    16257           
  Misses       1433     1433           
  Partials      329      329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TylerHelmuth
Copy link
Member Author

We'll go with the other PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant