Improve performance of internal traces to jaeger proto translation #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #906 +/- ##
=======================================
Coverage 85.12% 85.12%
=======================================
Files 174 174
Lines 13376 13410 +34
=======================================
+ Hits 11386 11415 +29
- Misses 1543 1545 +2
- Partials 447 450 +3
Continue to review full report at Codecov.
|
bogdandrutu
reviewed
May 1, 2020
Comment on lines
123
to
133
| if attrsCount == 0 { | ||
| return &process | ||
| } | ||
|
|
||
| tags := make([]model.KeyValue, 0, attrsCount) | ||
| process.Tags = appendTagsFromResourceAttributes(tags, attrs) | ||
| return &process | ||
|
|
||
| } | ||
|
|
||
| func attributesToJaegerProtoTags(attrs pdata.AttributeMap) []model.KeyValue { | ||
| func appendTagsFromResourceAttributes(dest []model.KeyValue, attrs pdata.AttributeMap) []model.KeyValue { |
There was a problem hiding this comment.
Simpler code:
process.Tags = appendTagsFromResourceAttributes(attrsCount, attrs)
return &process
func appendTagsFromResourceAttributes(attrs pdata.AttributeMap) []model.KeyValue {
if attrs.Cap() == 0 {
return nil
}
dest = make([]model.KeyValue, 0, attrs.Cap())
}
There was a problem hiding this comment.
It's not always the case that we can use attrs.Cap() as capacity for tags slice, that's why I moved it outside
There was a problem hiding this comment.
Hmm, confused, why, because we allocate 1 extra element?
There was a problem hiding this comment.
The similar function appendTagsFromAttributes needs to allocate more than attrs.Cap(), I kept the same approach here as well
This PR also fixes an attribute mutation bug when "service.name" got removed from resource data structure
203d477 to
97fe397
Compare
|
@bogdandrutu PTAL |
bogdandrutu
approved these changes
May 2, 2020
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
…pen-telemetry#906) This PR also fixes an attribute mutation bug when "service.name" got removed from resource data structure
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark results:
Before:
After: