make useOtelForInternalMetrics as beta #9037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While testing this change I came across a discrepancy in how the |
|
This is blocked by #9065 |
|
No longer blocked, it was decided to move ahead without #9065 |
bogdandrutu
approved these changes
Dec 12, 2023
|
Please add changelog |
added 2 commits
December 12, 2023 11:52
The metrics are now consistent with the metrics produced by OpenCensus. We should move the featuregate forward. Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
59516a6 to
d52f227
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9037 +/- ##
==========================================
+ Coverage 91.42% 91.53% +0.10%
==========================================
Files 316 316
Lines 17190 17210 +20
==========================================
+ Hits 15716 15753 +37
+ Misses 1173 1160 -13
+ Partials 301 297 -4 ☔ View full report in Codecov by Sentry. |
sokoide
pushed a commit
to sokoide/opentelemetry-collector
that referenced
this pull request
Dec 18, 2023
The metrics are now consistent with the metrics produced by OpenCensus. We should move the featuregate forward. Note that the OpenTelemetry generated metrics includes grpc client/server metrics (for receivers/exporters that use grpc) and `target_info` metrics Fixes open-telemetry#7454 --------- Signed-off-by: Alex Boten <aboten@lightstep.com>
dmitryax
pushed a commit
that referenced
this pull request
Jun 28, 2024
…10343) #### Description Fixing the bug: the latest version of otel-collector failed to start with ipv6 metrics endpoint service telemetry. This problem began to occur after #9037 with the feature gate flag enabled was merged. This problem is probably an implementation omission because the enabled codepath, which was originally added by #7871, is marked as WIP. You can reproduce the issue with the config and the environment variable (`MY_POD_IP=::1`). ```yaml service: telemetry: logs: encoding: json metrics: address: '[${env:MY_POD_IP}]:8888' ``` #### Link to tracking issue Fixes #10011 --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metrics are now consistent with the metrics produced by OpenCensus. We should move the featuregate forward.
Note that the OpenTelemetry generated metrics includes grpc client/server metrics (for receivers/exporters that use grpc) and
target_infometricsFixes #7454