Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add Logger field queue name, already configured #8879

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

bogdandrutu
Copy link
Member

These data are already logger fields, see https://github.com/open-telemetry/opentelemetry-collector/blob/main/service/internal/components/loggers.go#L40

  • ID is under name
  • DataType is under data_type

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested review from a team and djaglowski November 14, 2023 03:35
@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6c0bd4) 90.90% compared to head (3e4359c) 90.90%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8879      +/-   ##
==========================================
- Coverage   90.90%   90.90%   -0.01%     
==========================================
  Files         317      317              
  Lines       17229    17224       -5     
==========================================
- Hits        15662    15657       -5     
- Misses       1276     1277       +1     
+ Partials      291      290       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bogdandrutu bogdandrutu merged commit 1a21d18 into open-telemetry:main Nov 14, 2023
@bogdandrutu bogdandrutu deleted the dontaddqueuename branch November 14, 2023 04:18
@github-actions github-actions bot added this to the next release milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants