Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use standard component Start/Shutdown func in exporterhelper #8861

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Use standard component Start/Shutdown func in exporterhelper #8861

merged 1 commit into from
Nov 13, 2023

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested review from a team and djaglowski November 13, 2023 04:15
dmitryax
dmitryax approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the linter errors are fixed

@bogdandrutu bogdandrutu force-pushed the standardstart branch 2 times, most recently from 67df0bd to 403a729 Compare November 13, 2023 04:57
@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 13, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
exporter/exporterhelper/common.go 97.16% <100.00%> (-0.20%) ⬇️
...porter/exporterhelper/internal/persistent_queue.go 100.00% <100.00%> (ø)
exporter/exporterhelper/queue_sender.go 95.91% <100.00%> (ø)
exporter/exporterhelper/retry_sender.go 97.29% <100.00%> (ø)

📢 Thoughts on this report? Let us know!

@bogdandrutu
Use standard component Start/Shutdown func in exporterhelper
fd0fecc 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 23500dd into open-telemetry:main Nov 13, 2023
31 checks passed
@bogdandrutu bogdandrutu deleted the standardstart branch November 13, 2023 05:22
@github-actions github-actions bot added this to the next release milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.89.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bogdandrutu @dmitryax