Restructure Queue to not have to deal with consumers #8828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <bogdan.drutu@snowflake.com>
|
|
It's a good idea to move this from queue to the sender 👍 |
dmitryax
reviewed
Nov 9, 2023
Comment on lines
+3
to
+5
| go 1.21 | ||
|
|
||
| toolchain go1.21.3 |
dmitryax
reviewed
Nov 9, 2023
| @@ -14,11 +14,11 @@ import ( | |||
| "go.opentelemetry.io/collector/exporter/exporterhelper/internal" | |||
| ) | |||
|
|
|||
| // requestSender is an abstraction of a sender for a request independent of the type of the data (traces, metrics, logs). | |||
| // RequestSender is an abstraction of a sender for a request independent of the type of the data (traces, metrics, logs). | |||
There was a problem hiding this comment.
Suggested change
| // RequestSender is an abstraction of a sender for a request independent of the type of the data (traces, metrics, logs). | |
| // requestSender is an abstraction of a sender for a request independent of the type of the data (traces, metrics, logs). |
dmitryax
reviewed
Nov 10, 2023
| // capacity restrictions, returning true upon success and false if no space is currently available. | ||
| Offer(item Request) bool | ||
| // Poll retrieves and removes the head of this queue. | ||
| Poll() <-chan Request |
There was a problem hiding this comment.
The name seems a bit confusing, given that it returns a channel. Maybe Chan(), Out() or something like that?
This was referenced Nov 12, 2023
dmitryax
added a commit
that referenced
this pull request
Nov 15, 2023
Move the common workers loop logic from each queue implementation to the sender. Based on #8828
|
superseded by #8898 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important (read before submitting)
We are currently preparing for the upcoming 1.0 GA release. Pull requests that are not aligned with
the current roadmap https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/roadmap.md
and are not aimed at stabilizing and preparing the Collector for the release will not be accepted.
Delete this paragraph before submitting.
Description: <Describe what has changed.
Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.>
Link to tracking Issue:
Testing: < Describe what testing was performed and which tests were added.>
Documentation: < Describe the documentation added.>
Please delete paragraphs that you did not use before submitting.