Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split config/configtls module #7907

Merged

Conversation

codeboten
Copy link
Contributor

Part of #7895

Follow up to #7906

@codeboten codeboten force-pushed the codeboten/split-config-mod-tls branch from c417585 to d29567b Compare June 15, 2023 19:12
@codeboten codeboten force-pushed the codeboten/split-config-mod-tls branch from 4253ff8 to 485205d Compare June 15, 2023 22:50
go.mod Show resolved Hide resolved
Part of open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten force-pushed the codeboten/split-config-mod-tls branch from 485205d to ab1c085 Compare June 16, 2023 18:51
@codeboten codeboten marked this pull request as ready for review June 16, 2023 18:51
@codeboten codeboten requested review from a team and dmitryax June 16, 2023 18:51
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (c76fce7) 91.12% compared to head (ab1c085) 91.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7907      +/-   ##
==========================================
- Coverage   91.12%   91.12%   -0.01%     
==========================================
  Files         298      298              
  Lines       14912    14912              
==========================================
- Hits        13589    13588       -1     
  Misses       1047     1047              
- Partials      276      277       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codeboten codeboten merged commit ca22f12 into open-telemetry:main Jun 16, 2023
@codeboten codeboten deleted the codeboten/split-config-mod-tls branch June 16, 2023 19:06
@github-actions github-actions bot added this to the next release milestone Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants