Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split config/confignet into its own module #7905

Merged

Conversation

codeboten
Copy link
Contributor

Part of #7895

Follow up to #7904

@codeboten codeboten force-pushed the codeboten/split-config-mod-net branch 3 times, most recently from 4bbcb6a to ba5d28b Compare June 16, 2023 17:31
@codeboten codeboten marked this pull request as ready for review June 16, 2023 17:31
@codeboten codeboten requested review from a team and Aneurysm9 June 16, 2023 17:31
Linked issue open-telemetry#7895

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten force-pushed the codeboten/split-config-mod-net branch from ba5d28b to ddd00eb Compare June 16, 2023 17:49
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05 🎉

Comparison is base (13e728e) 91.07% compared to head (ddd00eb) 91.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7905      +/-   ##
==========================================
+ Coverage   91.07%   91.12%   +0.05%     
==========================================
  Files         298      298              
  Lines       14912    14912              
==========================================
+ Hits        13581    13589       +8     
+ Misses       1053     1047       -6     
+ Partials      278      276       -2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codeboten codeboten merged commit c76fce7 into open-telemetry:main Jun 16, 2023
@codeboten codeboten deleted the codeboten/split-config-mod-net branch June 16, 2023 18:13
@github-actions github-actions bot added this to the next release milestone Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants