[extension/auth] split into its own module #7883
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7883 +/- ##
=======================================
Coverage 91.14% 91.14%
=======================================
Files 298 298
Lines 14912 14912
=======================================
Hits 13591 13591
Misses 1045 1045
Partials 276 276 ☔ View full report in Codecov by Sentry. |
f2d21c5 to
479ff98
Compare
| @@ -53,6 +53,8 @@ replace go.opentelemetry.io/collector/exporter => ../../exporter | |||
|
|
|||
| replace go.opentelemetry.io/collector/extension => ../ | |||
|
|
|||
| replace go.opentelemetry.io/collector/extension/auth => ../auth | |||
There was a problem hiding this comment.
Interesting, why does the ballast extension has a dependency on the auth package?
There was a problem hiding this comment.
it does not... crosslink adds the replace in here automatically
There was a problem hiding this comment.
Is there any chance that this is a transient dependency?
There was a problem hiding this comment.
I removed the replace statement, ran the tests, and it worked without implying further changes to go.sum nor go.mod. Meaning: it's not a transitive dependency.
There was a problem hiding this comment.
I did the same then CI failed because of the crosslink check 🤣
Linked issue open-telemetry#7054 Signed-off-by: Alex Boten <aboten@lightstep.com>
479ff98 to
52bce16
Compare
Linked issue #7054