Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use http constants to replace numbers as parameters #7216

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Feb 19, 2023

Important (read before submitting)

We are currently preparing for the upcoming 1.0 GA release. Pull requests that are not aligned with
the current roadmap https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/roadmap.md
and are not aimed at stabilizing and preparing the Collector for the release will not be accepted.

Delete this paragraph before submitting.

Description: <Describe what has changed.
Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.>
Use http constants to replace numbers as parameters

Link to tracking Issue:

Testing: < Describe what testing was performed and which tests were added.>

Documentation: < Describe the documentation added.>

Please delete paragraphs that you did not use before submitting.

@my-git9 my-git9 requested review from a team and dmitryax February 19, 2023 12:29
Signed-off-by: xin.li <xin.li@daocloud.io>
@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Base: 90.99% // Head: 90.99% // No change to project coverage 👍

Coverage data is based on head (6e1a77a) compared to base (d2869f0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7216   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files         293      293           
  Lines       14267    14267           
=======================================
  Hits        12982    12982           
  Misses       1017     1017           
  Partials      268      268           
Impacted Files Coverage Δ
obsreport/obsreporttest/otelprometheuschecker.go 94.95% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 20, 2023
@bogdandrutu bogdandrutu merged commit fc88283 into open-telemetry:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants