Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] fix nits in persistent queue implementation #7203

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Feb 16, 2023

  • Remove unused members
  • Fix tests assert vs require, and usage of Eventually when not needed.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested review from a team and codeboten February 16, 2023 00:13
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 90.99% // Head: 90.99% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (ebaae1a) compared to base (8bf3885).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7203      +/-   ##
==========================================
- Coverage   90.99%   90.99%   -0.01%     
==========================================
  Files         293      293              
  Lines       14271    14267       -4     
==========================================
- Hits        12986    12982       -4     
  Misses       1017     1017              
  Partials      268      268              
Impacted Files Coverage Δ
...porter/exporterhelper/internal/persistent_queue.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu merged commit fbbb99e into open-telemetry:main Feb 16, 2023
@bogdandrutu bogdandrutu deleted the nitspersistent branch February 16, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants