Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node builders for receiver, processor, exporter #7030

Closed

Conversation

djaglowski
Copy link
Member

Continuation of #7026

@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 26, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 89.98% // Head: 89.81% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (64d8d25) compared to base (12c782d).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7030      +/-   ##
==========================================
- Coverage   89.98%   89.81%   -0.17%     
==========================================
  Files         245      245              
  Lines       14702    14729      +27     
==========================================
  Hits        13229    13229              
- Misses       1204     1231      +27     
  Partials      269      269              
Impacted Files Coverage Δ
service/nodes.go 3.44% <0.00%> (-1.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djaglowski djaglowski marked this pull request as ready for review January 26, 2023 05:48
@djaglowski djaglowski requested review from a team and bogdandrutu January 26, 2023 05:48
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems like it brings the project coverage below the threshold. If would e great if we could add some coverage soon

@djaglowski
Copy link
Member Author

@dmitryax, I'm happy to offer #7045 as an alternative or at least as proof that I have substantial test coverage ready. I would be quite happy to have these tests in place sooner rather than later.

@djaglowski
Copy link
Member Author

Closing in favor of #7045

@djaglowski djaglowski closed this Jan 31, 2023
@djaglowski djaglowski deleted the connectors-node-builders2 branch January 31, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:connector Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants