Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add connector.Builder #6867

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Add connector.Builder #6867

merged 1 commit into from
Jan 9, 2023

Conversation

djaglowski
Copy link
Member

No description provided.

@djaglowski djaglowski mentioned this pull request Dec 29, 2022
Merged
@codecov
Copy link

codecov bot commented Dec 29, 2022 •
edited
Loading

Codecov Report

Base: 91.05% // Head: 91.13% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (d0a28d3) compared to base (1f3c5fb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6867      +/-   ##
==========================================
+ Coverage   91.05%   91.13%   +0.07%     
==========================================
  Files         237      237              
  Lines       14306    14420     +114     
==========================================
+ Hits        13027    13141     +114     
  Misses       1027     1027              
  Partials      252      252
Impacted Files Coverage Δ
connector/connector.go 100.00% <100.00%> (ø)
connector/connectortest/connector.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djaglowski djaglowski mentioned this pull request Dec 29, 2022
Merged
@djaglowski djaglowski marked this pull request as ready for review December 29, 2022 20:51
@djaglowski djaglowski requested review from a team and codeboten December 29, 2022 20:51
@djaglowski djaglowski mentioned this pull request Jan 3, 2023
Closed
@djaglowski
Copy link
Member Author

@bogdandrutu, this PR is ready for review.

bogdandrutu
bogdandrutu approved these changes Jan 4, 2023
View reviewed changes
connector/connector.go Show resolved Hide resolved
@djaglowski
Copy link
Member Author

This should be ready to merge.

@bogdandrutu
Copy link
Member

Please rebase

@djaglowski
Copy link
Member Author

Rebased

@bogdandrutu bogdandrutu merged commit 1838b8b into open-telemetry:main Jan 9, 2023
@djaglowski djaglowski deleted the connector-builder branch January 9, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@codeboten codeboten Awaiting requested review from codeboten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djaglowski @bogdandrutu