Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark as deprecated componenttest exporter related funcs #6707

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 8, 2022
@bogdandrutu bogdandrutu requested review from a team and jpkrohling December 8, 2022 02:17
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 90.36% // Head: 90.36% // No change to project coverage 👍

Coverage data is based on head (e0e6c00) compared to base (2a931d9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6707   +/-   ##
=======================================
  Coverage   90.36%   90.36%           
=======================================
  Files         244      244           
  Lines       14161    14161           
=======================================
  Hits        12796    12796           
  Misses       1115     1115           
  Partials      250      250           
Impacted Files Coverage Δ
component/componenttest/nop_exporter.go 0.00% <ø> (ø)
obsreport/obsreporttest/obsreporttest.go 71.56% <100.00%> (ø)
component/componenttest/nop_factories.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu merged commit c56b7d3 into open-telemetry:main Dec 8, 2022
@bogdandrutu bogdandrutu deleted the markdeprecated branch December 8, 2022 03:44
jaronoff97 added a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
…ry#6707)

* Mark as deprecated componenttest exporter related funcs

This was a miss from open-telemetry#6672

Skipping changelog since covered in https://github.com/open-telemetry/opentelemetry-collector/blob/main/.chloggen/deprecatecompexp.yaml

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update deprecatecompexp.yaml

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
jaronoff97 added a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
…ry#6707)

* Mark as deprecated componenttest exporter related funcs

This was a miss from open-telemetry#6672

Skipping changelog since covered in https://github.com/open-telemetry/opentelemetry-collector/blob/main/.chloggen/deprecatecompexp.yaml

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update deprecatecompexp.yaml

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants