Move service.[Collector|NewSvcHandler|CollectorSettings|State|NewCommand] to collector package #6608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.87% // Head: 90.89% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6608 +/- ##
==========================================
+ Coverage 90.87% 90.89% +0.02%
==========================================
Files 244 244
Lines 14165 14161 -4
==========================================
Hits 12872 12872
+ Misses 1043 1039 -4
Partials 250 250
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
a9d4c0b to
fcedaef
Compare
codeboten
reviewed
Nov 28, 2022
fcedaef to
782818a
Compare
becf08f to
6f4ef86
Compare
|
This is part of #5564, right? Can we link it in the description? |
dmitryax
approved these changes
Dec 5, 2022
6f4ef86 to
0e4a121
Compare
* Instrument obsreport.Processor * add processor promchecker tests * add chloggen * run make genpdata and fix linter errors * address review feedback and retest * pass cfg into createOtelMetrics
0e4a121 to
6d9b1c0
Compare
codeboten
approved these changes
Dec 6, 2022
Co-authored-by: Alex Boten <alex@boten.ca>
Co-authored-by: Alex Boten <alex@boten.ca>
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
…and] to collector package (open-telemetry#6608) * Instrument obsreport.Processor (open-telemetry#6607) * Instrument obsreport.Processor * add processor promchecker tests * add chloggen * run make genpdata and fix linter errors * address review feedback and retest * pass cfg into createOtelMetrics * Update otelcol/moved.go Co-authored-by: Alex Boten <alex@boten.ca> * Update service/collector.go Co-authored-by: Alex Boten <alex@boten.ca> Co-authored-by: Moh Osman <59479562+moh-osman3@users.noreply.github.com> Co-authored-by: Alex Boten <alex@boten.ca>
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
…and] to collector package (open-telemetry#6608) * Instrument obsreport.Processor (open-telemetry#6607) * Instrument obsreport.Processor * add processor promchecker tests * add chloggen * run make genpdata and fix linter errors * address review feedback and retest * pass cfg into createOtelMetrics * Update otelcol/moved.go Co-authored-by: Alex Boten <alex@boten.ca> * Update service/collector.go Co-authored-by: Alex Boten <alex@boten.ca> Co-authored-by: Moh Osman <59479562+moh-osman3@users.noreply.github.com> Co-authored-by: Alex Boten <alex@boten.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #5564