Deprecate Config.Validate() in favor of component.ValidateConfig #6572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is "split" from open-telemetry#6544, to avoid breaking changes and go via deprecation. It is a bit hacky, but better than breaking everyone who uses this interface. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2a94a3c to
5e3e44c
Compare
Codecov ReportBase: 90.99% // Head: 90.95% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6572 +/- ##
==========================================
- Coverage 90.99% 90.95% -0.04%
==========================================
Files 241 241
Lines 14014 14025 +11
==========================================
+ Hits 12752 12757 +5
- Misses 1013 1019 +6
Partials 249 249
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dmitryax
reviewed
Nov 17, 2022
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
codeboten
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is "split" from #6544, to avoid breaking changes and go via deprecation.
It is a bit hacky, but better than breaking everyone who uses this interface.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com